-
-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix memory safety problem with Array.from_cpointer #3675
Conversation
Hi @ergl, The changelog - fixed label was added to this pull request; all PRs with a changelog label need to have release notes included as part of the PR. If you haven't added release notes already, please do. Release notes are added by creating a uniquely named file in the The basic format of the release notes (using markdown) should be:
Thanks. |
Not sure what's up with that failed check, it's erroring with |
There's a bug I'm working on that causes periodic segfaults. That's probably what the issue is. |
@@ -0,0 +1,7 @@ | |||
## Fix memory safety problem with Array.from_cpointer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent title.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for all the fixes
@SeanTAllen This should be ready to merge, I believe. Do you want to wait until the periodic segfault issue is resolved? |
@ergl I'm going to wait to merge for a bit until hopefully the segfault is resolved. The next release is in 3 weeks (if not sooner). It should definitely be merged by then. |
Fixes #3668. String already checked for a potential null pointer before constructing, so it was safe. Also added a test case to check this.